Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package should not require react-hot-loader to run #77

Closed
andrewliebchen opened this issue Feb 17, 2019 · 2 comments · Fixed by #119
Closed

Package should not require react-hot-loader to run #77

andrewliebchen opened this issue Feb 17, 2019 · 2 comments · Fixed by #119

Comments

@andrewliebchen
Copy link

When installing with yarn add on a app created with create-react-app, I get the following error:

Error: ENOENT: no such file or directory, open '.../node_modules/react-hot-loader/index.js'

Error goes away if I add react-hot-loader, but I'm not it's actually needed for the core functionality of the package.

@dolezel
Copy link
Owner

dolezel commented Feb 25, 2019

That's probably bug in yarn. This package has react-hot-loader only in devDependencies which should not be installed when adding package. They are only for development purposes...

@andrewliebchen
Copy link
Author

I wondered if this was a problem too...however, this can't be the only package on npm that use react-hot for it's dev setup. Is this just a problem for every package installed with Yarn that uses react-hot? Or is there a config that fixes it.

Either way, minor problem. Great package thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants