SysConf: std::move name in Entry constructor

Allows code to move into the constructor, avoiding copies entirely.
dolphin-emu · Dec 30, 2020 · 1bbfde6 · 1bbfde6
1 parent 05094ab
commit 1bbfde6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/Source/Core/Core/SysConf.cpp b/Source/Core/Core/SysConf.cpp
@@ -211,14 +211,14 @@ bool SysConf::Save() const
   return result == IOS::HLE::FS::ResultCode::Success;
 }
 
-SysConf::Entry::Entry(Type type_, const std::string& name_) : type(type_), name(name_)
+SysConf::Entry::Entry(Type type_, std::string name_) : type(type_), name(std::move(name_))
 {
   if (type != Type::SmallArray && type != Type::BigArray)
     bytes.resize(GetNonArrayEntrySize(type));
 }
 
-SysConf::Entry::Entry(Type type_, const std::string& name_, std::vector<u8> bytes_)
-    : type(type_), name(name_), bytes(std::move(bytes_))
+SysConf::Entry::Entry(Type type_, std::string name_, std::vector<u8> bytes_)
+    : type(type_), name(std::move(name_)), bytes(std::move(bytes_))
 {
 }
 

diff --git a/Source/Core/Core/SysConf.h b/Source/Core/Core/SysConf.h
@@ -47,8 +47,8 @@ class SysConf final
       ByteBool = 7,
     };
 
-    Entry(Type type_, const std::string& name_);
-    Entry(Type type_, const std::string& name_, std::vector<u8> bytes_);
+    Entry(Type type_, std::string name_);
+    Entry(Type type_, std::string name_, std::vector<u8> bytes_);
 
     // Intended for use with the non array types.
     template <typename T>