Merge pull request #9754 from JosJuice/netplay-memcard-region

NetPlay: Check that memory card region is valid
dolphin-emu · May 27, 2021 · 52a388a · 52a388a
2 parents e32cf29 + ba7ad73
commit 52a388a
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/Source/Core/Core/NetPlayClient.cpp b/Source/Core/Core/NetPlayClient.cpp
@@ -859,6 +859,13 @@ unsigned int NetPlayClient::OnData(sf::Packet& packet)
       bool mc251;
       packet >> is_slot_a >> region >> mc251;
 
+      // This check is mainly intended to filter out characters which have special meanings in paths
+      if (region != JAP_DIR && region != USA_DIR && region != EUR_DIR)
+      {
+        SyncSaveDataResponse(false);
+        return 0;
+      }
+
       const std::string path = File::GetUserPath(D_GCUSER_IDX) + GC_MEMCARD_NETPLAY +
                                (is_slot_a ? "A." : "B.") + region + (mc251 ? ".251" : "") + ".raw";
       if (File::Exists(path) && !File::Delete(path))