New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VideoConfig: Add flag for whether the system supports setting object names #10422
Conversation
c6139fd
to
574e574
Compare
You're missing includes for |
574e574
to
09b7383
Compare
Fixed, thanks. |
You're only setting Also, to make sure, |
This reverts commit 2ab6639.
…tialization result
09b7383
to
8be3572
Compare
Fixed. And, yes, I believe so. Otherwise, the driver would be in violation of the spec. |
Basically, the proper version of #10342.
A flag has been added to
VideoConfig
:bSupportsSettingObjectNames
. This is now checked before callingglObjectLabel
in the OpenGL backend andvkSetDebugUtilsObjectNameEXT
in the Vulkan backend.For the OpenGL backend, support is only set if on OpenGL >4.3 or OpenGL ES 3.2. This fixes a crash when using the OpenGL backend on macOS, the Android Emulator, and probably some other devices.
For the Vulkan backend, support is only set if the
VK_EXT_debug_utils
extension was loaded correctly. In addition, a bug has been fixed wherevkSetDebugUtilsObjectNameEXT
was loaded as if it were a device function. It is actually an instance function. (This caused Dolphin to fail when loading the function from MoltenVK.)For the Direct3D backends, support is assumed because I haven't heard of any crashing related to this.