Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoCommon: Clear backend_info before populating #10842

Merged
merged 1 commit into from Jul 13, 2022

Conversation

TellowKrinkle
Copy link
Contributor

Removes the requirement that backends manually populate every field in backend_info (they now only have to populate features that differ from the default value)

Fixes an issue where switching from a renderer that supported Framebuffer Fetch (e.g. MoltenVK or Metal) to OpenGL would leave the fbfetch support flag enabled.

Alternative Option: Fix the one bug in OpenGL and hope it's the only one like it

Copy link
Contributor

@iwubcode iwubcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested. Seems reasonable to me.

@JMC47 JMC47 merged commit 5663a44 into dolphin-emu:master Jul 13, 2022
@Pokechu22
Copy link
Contributor

This isn't the first time a bug like this has happened; see #10444 (and #10422, where I caught one case of a field not being initialized, but missed the other one), So, clearing it is definitely a good idea.

@TellowKrinkle TellowKrinkle deleted the ClearBackendInfo branch July 13, 2022 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants