Resolve Linux GCC Warnings #10624
Merged
Resolve Linux GCC Warnings #10624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
reviewed
May 1, 2022
Minty-Meeo
force-pushed
the
resolve-gcc-warnings
branch
from
9df1fab
to
7c6543c
Compare
Pokechu22
reviewed
May 1, 2022
Minty-Meeo
force-pushed
the
resolve-gcc-warnings
branch
from
7c6543c
to
2b8842c
Compare
shuffle2
reviewed
Jun 4, 2022
| @@ -55,10 +55,10 @@ struct SlopeContext | |||
| struct Slope | |||
| { | |||
| Slope() = default; | |||
| Slope(float f0, float f1, float f2, const SlopeContext& ctx) : f0(f0) | |||
| Slope(float f0_, float f1_, float f2_, const SlopeContext& ctx) : f0(f0_) | |||
There was a problem hiding this comment.
IMO it’s nicer to make the change to the internal var name instead of the name used in exposed declaration (also what Google coding standard suggests)
There was a problem hiding this comment.
I disagree, but if it makes it consistent with other code, sure.
There was a problem hiding this comment.
I can see the argument for this with private members variables, but when they're public this makes the constructor nicer at the expense of making every other access to the struct members uglier.
I believe Google's style guide agrees with me here ("Class Data Members" vs "Struct Data Members").
Minty-Meeo
force-pushed
the
resolve-gcc-warnings
branch
from
2b8842c
to
6c699ce
Compare
|
This PR is not dead btw |
Minty-Meeo
force-pushed
the
resolve-gcc-warnings
branch
2 times, most recently
from
2e1f1f2
to
4984f9f
Compare
Minty-Meeo
force-pushed
the
resolve-gcc-warnings
branch
from
4984f9f
to
69e32de
Compare
|
Is there anything else that needs to be done, or is this just waiting for review? |
Dentomologist
approved these changes
Jul 2, 2022
Pokechu22
approved these changes
Jul 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These annoyed me, so I fixed them.
These warnings are being resolved by #10610
/Core/Common/FifoPlayer.cpp : void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘struct CPState’ with no trivial copy-assignment; use copy-initialization instead [-Wclass-memaccess]
/Core/VideoCommon/CPMemory.cpp : void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘struct CPState’ with no trivial copy-assignment; use copy-initialization instead [-Wclass-memaccess]
This warning is being resolved by #10374
/Core/Core/HW/EXI/EXI.h : 'ExpansionInterface::SLOTS’ defined but not used [-Wunused-variable]