IOS/ES: Add support for V1Ticket

[noahpistilli]

Adds support for the V1Ticket format within ES.

ES::TicketReader has been edited to support this format, as well as a couple ES IOCTLV's.

I have only encountered this file format within the Japanese channel Wii no Ma, where it is used in the theatre to track purchased movies. This has been tested with that channel and works perfectly.

[AdmiralCurtiss]

@leoetlino You're probably the right person to review this?

[leoetlino]

Huh, so v1 tickets are used after all... interesting. I'm currently sick but I'll try to review this by the end of this week

[iwubcode]

The optional size seems unnecessary. Couldn't you just use u32*. Then just pass nullptr in the case below where ticket != nullptr.

[sepalani]

On top of what @iwubcode said (regarding optional and nullptr), is there a reason not to move the V1 specific code to GetV0TicketFromView and maybe rename the function since V0/V1 almost look like the same?

[iwubcode]

This is just a suggestion but I wonder if the code would be clearer as two functions:

ReturnCode GetV1TicketFromViewAndExistingTicket(const u8* ticket_view, u8* ticket) const
{
  // same as current function except remove the code for ticket_size
}


ReturnCode GetV1TicketFromViewAndSize(const u8* ticket_view, u32* ticket_size) const
{
  const u64 title_id = Common::swap64(&ticket_view[offsetof(ES::TicketView, title_id)]);

  const auto installed_ticket = FindSignedTicket(title_id);
  if (!installed_ticket.IsValid())
    return ES_NO_TICKET;

   *ticket_size = installed_ticket.GetTicketSize();
    return IPC_SUCCESS;
}

then

ReturnCode ESDevice::GetTicketFromView(const u8* ticket_view, u8* ticket, u32* ticket_size) const
{
  const u8 version = ticket_view[offsetof(ES::TicketView, version)];
  if (version == 1)
  {
    if (ticket == nullptr)
      return GetV1TicketFromViewAndSize(ticket_view, ticket_size);
    return GetV1TicketFromViewAndExistingTicket(ticket_view, ticket);
  }
  ...
}

[sepalani]

Another way would be to make GetTicketFromView, GetV0TicketFromView and GetV1TicketFromView a single function.

AFAICT, GetTicketFromView set *ticket_size just like GetV1TicketFromView and GetV1TicketFromView behaves like GetV0TicketFromView but adds a size check.

[noahpistilli]

This does sound like a better way to do it, will change.

[sepalani]

Can't it be simplified as return m_bytes.size() == GetTicketSize()?

[sepalani]

On top of what @iwubcode said (regarding optional and nullptr), is there a reason not to move the V1 specific code to GetV0TicketFromView and maybe rename the function since V0/V1 almost look like the same?

[sepalani]

Another way would be to make GetTicketFromView, GetV0TicketFromView and GetV1TicketFromView a single function.

AFAICT, GetTicketFromView set *ticket_size just like GetV1TicketFromView and GetV1TicketFromView behaves like GetV0TicketFromView but adds a size check.

[leoetlino]

Other ES commands that we might(?) want to update to add v1 ticket support:

• ticket imports
• ticket deletions
• ticket listing (ESDevice::GetTitlesWithTickets should be updated to check for .tv1 files in addition to .tik)

[noahpistilli]

I have tested ticket imports which works correctly, however I have not tested deletion yet.

I also condensed the GetTicketFromView, GetV0TicketFromView and GetV1TicketFromView functions into one function as @sepalani and @iwubcode have suggested.

[noahpistilli]

If that is all would you like me to squash the commits?

[leoetlino]

LGTM other than the lint issues. (And yes, please squash the commits)

[leoetlino]

LGTM. Feel free to ignore the FifoCI diff (which is unrelated) and squash the commits.