Eliminate SettingsHandler's SetBytes and Reset methods
#12737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought this change was worth making in isolation, but let me know if it would make more sense to bundle this change into a single PR that also splits |
JosJuice
reviewed
Apr 23, 2024
Also make the `Decrypt` method private. As far as I can tell, the only motivation for exposing the `SetBytes` and `Reset` methods is to allow `CBoot::SetupWiiMemory` to use the same `SettingsHandler` instance to read settings data and then write it back. It seems cleaner to just use two separate instances, and require a given `SettingsHandler` instance to be used for either writing data to a buffer or reading data from a buffer, but not both. A natural next step is to split the `SettingsHandler` class into two classes, one for writing data and one for reading data. I've deferred that change for a future PR.
nlebeck
force-pushed
the
settingshandler-split
branch
from
8f1f4bd
to
36cdb4a
Compare
|
Thanks! Also addressed the linter issue. |
JosJuice
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make the
Decryptmethod private.As far as I can tell, the only motivation for exposing the
SetBytesandResetmethods is to allowCBoot::SetupWiiMemoryto use the sameSettingsHandlerinstance to read settings data and then write it back. It seems cleaner to just use two separate instances, and require a givenSettingsHandlerinstance to be used for either writing data to a buffer or reading data from a buffer, but not both.A natural next step is to split the
SettingsHandlerclass into two classes, one for writing data and one for reading data. I've deferred that change for a future PR.