DiscIO: Improve error handling for reading integers #3127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| bool CBlobBigEndianReader::Read16(u64 offset, u16* buffer) const | ||
| { | ||
| if (!m_reader.Read(offset, sizeof(u16), (u8*)buffer)) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
JosJuice
force-pushed
the
read-return
branch
5 times, most recently
from
94423eb
to
21c8743
Compare
|
Fixes the crash when loading game list. |
JosJuice
force-pushed
the
read-return
branch
4 times, most recently
from
4c5db4b
to
4ceb33a
Compare
JosJuice
force-pushed
the
read-return
branch
2 times, most recently
from
e8fd65d
to
f131d94
Compare
|
Any reason not to merge this? |
|
|
||
| bool Read32(u64 offset, u32* buffer) const; | ||
| bool Read16(u64 offset, u16* buffer) const; | ||
| bool Read8(u64 offset, u8* buffer) const; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
LGTM |
JosJuice
force-pushed
the
read-return
branch
2 times, most recently
from
b61f46b
to
91b78e9
Compare
|
Bump |
Callers can now check whether reads fail, either by checking the return value or by setting the buffer to a known bad value and seeing if it stays untouched. I've added error checks to FileSystemGCWii and Boot_BS2Emu, but not to Boot since it doesn't check any of its other reads either.
JosJuice
force-pushed
the
read-return
branch
from
91b78e9
to
cbfab2a
Compare
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
degasus
added a commit
that referenced
this pull request
Dec 15, 2015
DiscIO: Improve error handling for reading integers
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://bugs.dolphin-emu.org/issues/9002