TAS dialog: Toggle analog inputs between TAS and regular input

[rukai]

Solves https://bugs.dolphin-emu.org/issues/9325

As suggested by @Sonicadvance1 I have added a toggle button for each analog input allowing the user to have fine grained control over whether each analog input should be taken from the TAS input or its regular input. Digital inputs remain as they were, deciding which input to take automatically
input = TASInput && regularInput

Previously the code assumed a keyboard input which is not compatible with analog inputs.

@MaJoRoesch Can you please make a proper icon for this?

[BhaaLseN]

Got a screenshot?

---

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Source/Core/DolphinWX/TASInputDlg.h, line 147 [r1] (raw file):
Alignment looks off here; Tabs for indent., then spaces for alignment if necessary - this line seems to be all spaces.

---

Comments from the review on Reviewable.io

[BhaaLseN]

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from the review on Reviewable.io

[rukai]

Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Source/Core/DolphinWX/TASInputDlg.h, line 147 [r1] (raw file):
Done.

---

Comments from the review on Reviewable.io

[JosJuice]

Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

---

Source/Core/DolphinWX/TASInputDlg.cpp, line 44 [r2] (raw file):
This is wrong. The original alignment is the correct one.

---

Source/Core/DolphinWX/TASInputDlg.h, line 30 [r2] (raw file):
Same here.

---

Comments from the review on Reviewable.io

[lioncash]

Review status: all files reviewed at latest revision, 8 unresolved discussions.

---

a discussion (no related file):
There should be a tooltip set for the lock buttons that explain what they do. Also the lock buttons should be considerably smaller to fit the UI. It's almost overlapping the depression that indicates the shoulder buttons. It would likely be a better idea to place the button under the slider value indicators for them as well.

---

Source/Core/DolphinWX/TASInputDlg.cpp, line 1137 [r2] (raw file):
This event table can be replaced with a Bind call in the constructor .

Bind(wxEVT_TOGGLEBUTTON, &TASInputDlg::OnLockToggle, this);

---

Source/Core/DolphinWX/TASInputDlg.h, line 11 [r2] (raw file):
this can be replaced with a forward declaration. The include can then be moved to the cpp file to avoid cluttering anything that includes the TAS header.

---

Source/Core/DolphinWX/TASInputDlg.h, line 66 [r2] (raw file):
lowercase tas

---

Source/Core/DolphinWX/TASInputDlg.h, line 148 [r2] (raw file):
m_locked_graphic
m_unlocked_graphic

---

Source/Core/DolphinWX/TASInputDlg.h, line 149 [r2] (raw file):
This should be placed with all the other functions.

---

Comments from the review on Reviewable.io

[RisingFog]

@rukai anything left with this PR?

[rukai]

@RisingFog Yeah, still need a proper icon for it. @MaJoRoesch seems really busy these days, is there anyone else who could make/find one? Or alternatively is there a more suitable UI element we could use here instead of a lock icon?

[ghost]

Not sure if this is really related to the PR but is there a reason why the circle is being rendered (1, 1) off-centre or is that intended? I know that happens in master too.

[ghost]

The issue I noted in my previous post turned out to be a wxWidgets problem and is fixed now as of 5.0-211.

[RisingFog]

This PR will need to be rebased.

If I don't see any response within two weeks, I'll rebase and re-submit a PR for this.

[shuffle2]

Moving to #4265