-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various Linux fixes #3705
Various Linux fixes #3705
Conversation
I don't think the version bump is necessary, 5.0 hasn't come out yet |
Considering it's the development branch and 5.0RC has been tagged, I figured it could be safely changed. If not, just cherry pick out that commit. The only other thing I changed in the commit was polarssl -> mbedtls, as the package was renamed in Fedora. |
The RC system was scrapped. |
Dolphin is a Gamecube, Wii and Triforce (the arcade machine based on the | ||
Gamecube) emulator, which supports full HD video with several enhancements such | ||
as compatibility with all PC controllers, turbo speed, networked multiplayer, | ||
and more. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
I've made some changes based on the input provided:
|
Feel free to squash those last 3 changes into their respective commits to keep things tidy. |
Reviewed 2 of 2 files at r3. Installer/dolphin-emu-nogui.6, line 3 [r2] (raw file): Installer/dolphin-emu-nogui.6, line 7 [r2] (raw file): Installer/dolphin-emu-nogui.6, line 17 [r2] (raw file): There are also some more options not listed in the readme. Installer/dolphin-emu-nogui.6, line 29 [r2] (raw file): Installer/dolphin-emu-nogui.6, line 39 [r2] (raw file): Installer/dolphin-emu.6, line 1 [r3] (raw file): Comments from the review on Reviewable.io |
Done, squashed into 3 commits.
|
Google Test recommends against using precompiled system libararies, are you sure this is a good idea? |
And then you have other distros (such as Debian / Ubuntu) which ship a shared copy of the source only in /usr/src/gtest to get around the issues Google raised. Should these distros be supported too? |
In practice there is no reason to care about GTest being statically linked. It's not linked into our main binary, only in unit tests that aren't being distributed to end users. So I would recommend reverting that part of the pull request and keeping the static linking to our Externals copy. |
I changed shared gtest to be an option that's disabled by default. I can't make a solution for Debian or Ubuntu, as I don't use these distros and can't test this properly. If desired, an extra check can be added later. |
@@ -952,6 +960,11 @@ if(${CMAKE_SYSTEM_NAME} STREQUAL "Linux") | |||
DESTINATION ${CMAKE_INSTALL_PREFIX}/share/icons/hicolor/48x48/apps) | |||
install(FILES Installer/dolphin-emu.desktop | |||
DESTINATION ${CMAKE_INSTALL_PREFIX}/share/applications) | |||
# Install manpages | |||
install(FILES Installer/dolphin-emu.6 | |||
DESTINATION ${CMAKE_INSTALL_PREFIX}/usr/share/man/man6) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Note that the manpages are placed in Data
Alright, I've moved the manpages to Data, and in a separate commit, I moved the Linux specific data files to Data as well. |
This adds 5 files to the Windows build. Is that intended? |
No, I'm assuming this is an error in the windows build, where it includes everything from the Data folder (Note that I am not a windows user or developer). The windows build needs to be changed to exclude these files and not just copy the hold Data folder. |
Three fixes/commits:
https://bugs.dolphin-emu.org/issues/9402
https://bugs.dolphin-emu.org/issues/9403
Thanks!