-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Game INI updates #3768
Game INI updates #3768
Conversation
Why not enforce real xfb in Mortal Kombat? All of these entries can be easily changed afterwards with batch editing when Hybrid Xfb is done although i admit i don't have a clue when that may be. |
It seems like the main part of the game doesn't require real XFB, and I thought it would be better to not force 1x resolution for something optional. That we can batch edit this when hybrid XFB becomes available is a good point, but 5.0 will not have hybrid XFB, so I prefer this for now. |
So, when will this be looked over? |
Now also fixes https://bugs.dolphin-emu.org/issues/9490 |
c500752
to
3f6db81
Compare
Reviewed 7 of 8 files at r1, 3 of 4 files at r2, 3 of 3 files at r3. Data/Sys/GameSettings/RUU.ini, line 25 [r3] (raw file): Data/Sys/GameSettings/SNG.ini, line 21 [r3] (raw file): Data/Sys/GameSettings/WPA.ini, line 21 [r3] (raw file): Comments from Reviewable |
I agree with both comments about safe texture settings. Unless it's necessary, I don't think it should be in a gameini. EDIT: To the first two |
Review status: 13 of 14 files reviewed at latest revision, 3 unresolved discussions. Data/Sys/GameSettings/RUU.ini, line 25 [r3] (raw file): Data/Sys/GameSettings/SNG.ini, line 21 [r3] (raw file): Data/Sys/GameSettings/WPA.ini, line 21 [r3] (raw file): Comments from Reviewable |
Review status: 13 of 14 files reviewed at latest revision, 3 unresolved discussions. Data/Sys/GameSettings/WPA.ini, line 21 [r3] (raw file): Comments from Reviewable |
3f6db81
to
6da87ef
Compare
Is this good to merge? Closes a blocker~ |
3e357b2
to
a9f4373
Compare
a9f4373
to
0008f7e
Compare
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
A continuation of #3735, with additions based on the following reports:
https://bugs.dolphin-emu.org/issues/9465
https://forums.dolphin-emu.org/Thread-unreadable-characters-on-get-fith-with-mel-b
https://forums.dolphin-emu.org/Thread-gc-mortal-kombat-deadly-alliance--26173?pid=397717#pid397717
If there's anything that needs to be removed or changed (RMC.ini MSAA?), please tell me.
This change is