Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game INI updates #3768

Merged
merged 4 commits into from
May 1, 2016
Merged

Game INI updates #3768

merged 4 commits into from
May 1, 2016

Conversation

JosJuice
Copy link
Member

@JosJuice JosJuice commented Apr 3, 2016

A continuation of #3735, with additions based on the following reports:

https://bugs.dolphin-emu.org/issues/9465
https://forums.dolphin-emu.org/Thread-unreadable-characters-on-get-fith-with-mel-b
https://forums.dolphin-emu.org/Thread-gc-mortal-kombat-deadly-alliance--26173?pid=397717#pid397717

If there's anything that needs to be removed or changed (RMC.ini MSAA?), please tell me.


This change is Reviewable

@Linktothepast
Copy link
Contributor

Why not enforce real xfb in Mortal Kombat? All of these entries can be easily changed afterwards with batch editing when Hybrid Xfb is done although i admit i don't have a clue when that may be.

@JosJuice
Copy link
Member Author

JosJuice commented Apr 3, 2016

It seems like the main part of the game doesn't require real XFB, and I thought it would be better to not force 1x resolution for something optional. That we can batch edit this when hybrid XFB becomes available is a good point, but 5.0 will not have hybrid XFB, so I prefer this for now.

@MarioManTAW
Copy link
Contributor

So, when will this be looked over?

@JosJuice
Copy link
Member Author

Now also fixes https://bugs.dolphin-emu.org/issues/9490

@JMC47
Copy link
Contributor

JMC47 commented Apr 28, 2016

Reviewed 7 of 8 files at r1, 3 of 4 files at r2, 3 of 3 files at r3.
Review status: 13 of 14 files reviewed at latest revision, 3 unresolved discussions.


Data/Sys/GameSettings/RUU.ini, line 25 [r3] (raw file):
I don't like setting safe texture cache for non essential things. It's very demanding and causes slowdowns fairly commonly.


Data/Sys/GameSettings/SNG.ini, line 21 [r3] (raw file):
What is safe texture cache doing for this? Can you add that in emulation notes if it's neccessary?


Data/Sys/GameSettings/WPA.ini, line 21 [r3] (raw file):
I already know it's necessary in this game, but please note in the INI why it's set.


Comments from Reviewable

@Helios747
Copy link
Contributor

Helios747 commented Apr 28, 2016

I agree with both comments about safe texture settings. Unless it's necessary, I don't think it should be in a gameini.

EDIT: To the first two

@JosJuice
Copy link
Member Author

Review status: 13 of 14 files reviewed at latest revision, 3 unresolved discussions.


Data/Sys/GameSettings/RUU.ini, line 25 [r3] (raw file):
Good point. The pattern editor is a very tiny part of the game, so I will remove this along with ForceFiltering = False and make an emulation note instead.


Data/Sys/GameSettings/SNG.ini, line 21 [r3] (raw file):
The text gets messed up with fast texture cache. I'll add it to the emulation notes.


Data/Sys/GameSettings/WPA.ini, line 21 [r3] (raw file):
In the emulation notes, in a comment or both?


Comments from Reviewable

@JMC47
Copy link
Contributor

JMC47 commented Apr 30, 2016

Review status: 13 of 14 files reviewed at latest revision, 3 unresolved discussions.


Data/Sys/GameSettings/WPA.ini, line 21 [r3] (raw file):
I think emulation notes would be fine.


Comments from Reviewable

@Helios747
Copy link
Contributor

Is this good to merge? Closes a blocker~

@Parlane Parlane merged commit b779504 into dolphin-emu:master May 1, 2016
@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

automated-fifoci-reporter

@JosJuice JosJuice deleted the game-inis-2016-04-03 branch May 2, 2016 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

7 participants