VertexShaderGen: Move the sonic epsilon hack to the vertex shader. #4164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrossVR
force-pushed
the
sonic-clipping
branch
from
0a09674
to
6019b11
Compare
|
There are issues in ogl-lin-intel / nfsu-reflections, ogl-lin-intel / fishing-resort-map, ogl-lin-intel / inverted-depth-range, and potentially others. |
|
The latest run should have resolved them. |
|
ogl-lin-intel / fishing-resort-map appears to be fixed but the other two still exhibit changes. |
|
the other two are broken fifologs and should be ignored |
|
Things look fine now, but I'd still like some comment on whether my |
CrossVR
force-pushed
the
sonic-clipping
branch
from
6019b11
to
90a096e
Compare
|
Switched to an arbitrary small value after all. Note that simply using an epsilon value doesn't work, not even if I multiply it by z as would be implied by the projection matrix. |
CrossVR
force-pushed
the
sonic-clipping
branch
from
90a096e
to
11f3c0d
Compare
In the vertex shader we have control over the depth clipping planes, so we don't have to offset every floating point value and lose accuracy.
CrossVR
force-pushed
the
sonic-clipping
branch
from
11f3c0d
to
debaf63
Compare
|
I like to move those hacks to farer stages, so LGTM. But I have no clue about the impact on the z accuracy... |
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the vertex shader we have control over the depth clipping planes, so we don't have to offset every floating point value and lose accuracy. This fixes z fighting in the Metroid Prime visor. It also make slow depth a lot more accurate.
It has also been confirmed that the only reason the SW backend rendered the Sonic Adventure/Unleashed UIs correctly was because of its own version of the epsilon hack: https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/VideoBackends/Software/TransformUnit.cpp#L60
We can't use the exact same hack as the SW backend because our depth comparison is done in floats instead of integers and is therefore sensitive to rounding errors introduced by adding an epsilon to all depth values.
This change is