Move LogWindow/LogConfigWindow destructor logic -> OnClose

[ligfx]

Fixes the issue on macOS where quitting Dolphin from the Dock causes a crash report. I'm not exactly sure why this works, but it feels 🌟right🌟 and it fixes the problem.

---

This change is

[lioncash]

Source/Core/DolphinWX/LogWindow.cpp, line 157 at r1 (raw file):

  event.Skip();

  for (int i = 0; i < LogTypes::NUMBER_OF_LOGS; ++i)

This should be in its own function (RemoveAllListeners or something appropriate), which is called in OnClose()

---

Comments from Reviewable

[ligfx]

Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

Source/Core/DolphinWX/LogWindow.cpp, line 157 at r1 (raw file):

Previously, lioncash (Mat M.) wrote…

This should be in its own function (RemoveAllListeners or something appropriate), which is called in OnClose()

Done.

---

Comments from Reviewable

[endrift]

Whoa a fix for this crash, finally! I've seen this crash a handful of times but was never sure what caused it.

[lioncash]

LGTM once the merge commit is rebased out.

[leoetlino]

The commit title and message are a bit long (they should be about 52/72 characters long respectively). IMO, the title should be made shorter and the message should be wrapped to make it easier to read in a terminal and show up better even on GitHub.

[ligfx]

@leoetlino done

[shuffle2]

I had to revert some of this commit here #4292 could someone who was affected by it please look/test and see if I will regress you or not.