ESFormats: Minor changes #5700
Merged
ESFormats: Minor changes #5700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The title key is always 16 bytes, so it doesn't make sense to make it a std::vector.
Changes ESFormats to take an IOSC instance instead of creating its own temporary instance unnecessarily.
iwubcode
approved these changes
Jun 27, 2017
JosJuice
approved these changes
Jun 27, 2017
|
maybe in the future, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change title key related functions to use a std::array instead of std::vector. The title key is always 16 bytes, so it doesn't make sense to make it a std::vector.
Reuse the kernel IOSC instance whenever that's possible. Saves memory and there's no reason to create a temporary instance when there's already one around.