-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qt: Implement "Load System Menu" #5756
Conversation
Source/Core/DolphinQt2/Settings.cpp
Outdated
|
||
const QString Settings::GetInstalledWiiSystemMenuVersion() const | ||
{ | ||
const auto& sys_menu_loader = DiscIO::NANDContentManager::Access().GetNANDLoader( |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Hmm. Would there be a better home somewhere for the NAND-was-changed callback? Maybe WiiUtils, or somewhere in NAND or IOS? |
Source/Core/DolphinQt2/MenuBar.cpp
Outdated
@@ -268,10 +274,19 @@ void MenuBar::UpdateToolsMenu(bool emulation_started) | |||
{ | |||
const bool enable_wii_tools = !emulation_started || !SConfig::GetInstance().bWii; | |||
m_perform_online_update_menu->setEnabled(enable_wii_tools); | |||
|
|||
IOS::HLE::Kernel ios; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
I think keeping the reload logic in the UI code as it is currently is fine, as a NAND changed callback would be complex to implement (if we get Starlet LLE -- how do we know something changed?) or might not be useful (the UI code shouldn't access the NAND when emulation is running). |
Source/Core/DolphinQt2/Settings.cpp
Outdated
@@ -150,3 +150,8 @@ QVector<QString> Settings::GetProfiles(const InputConfig* config) const | |||
|
|||
return vec; | |||
} | |||
|
|||
void Settings::TriggerNANDRefresh() |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Source/Core/DolphinQt2/MenuBar.cpp
Outdated
@@ -267,11 +273,23 @@ void MenuBar::AddTableColumnsMenu(QMenu* view_menu) | |||
void MenuBar::UpdateToolsMenu(bool emulation_started) | |||
{ | |||
const bool enable_wii_tools = !emulation_started || !SConfig::GetInstance().bWii; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
m_boot_sysmenu = tools_menu->addAction(QStringLiteral(""), [this] { emit BootWiiSystemMenu(); }); | ||
m_boot_sysmenu->setEnabled(false); | ||
|
||
connect(&Settings::Instance(), &Settings::NANDRefresh, [this] { UpdateToolsMenu(false); }); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Source/Core/DolphinQt2/MenuBar.cpp
Outdated
QStringLiteral(""); | ||
m_boot_sysmenu->setText(tr("Load Wii System Menu %1").arg(sysmenu_version)); | ||
|
||
m_boot_sysmenu->setEnabled(!emulation_started && tmd.IsValid()); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
No description provided.