AI: Fix GameCube Sample Rate #6040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm for rewriting this stuff to return the number of cpu cycles for 8 audio samples. But this is a by far bigger change. So I think we should merge this code as it is for now. |
RisingFog
reviewed
Oct 18, 2017
| if (SConfig::GetInstance().bWii) | ||
| g_AIDSampleRate = tmpAICtrl.AIDFR ? 32000 : 48000; | ||
| else | ||
| g_AIDSampleRate = tmpAICtrl.AIDFR ? 32029 : 48043; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
The GameCube's sample rate is slightly different due to a hardware bug. The exact numbers are (54000000 / 1124) for GameCube and (54000000 / 1125) on Wii. I also modified 32KHz mode. This fixes audio desyncs in several GameCube games and severe issues in Sonic Mega Collection.
|
#dolphin-dev on irc.freenode.net would probably be the best place for that kind of discussion. Both JMC and degasus are there, along with most other devs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GameCube's sample rate is slightly different due to a hardware bug.
The exact numbers are (54000000 / 1124) for GameCube and (54000000 / 1125)
on Wii. I also modified 32KHz mode. This fixes audio desyncs in several
GameCube games and severe issues in Sonic Mega Collection.
TODO: Maybe not use an integer? That was beyond me to change though. Also this can probably be done better. I just wanted it available for testing. Seems to make Starfox Adventure's Dialogue line up better too, but, I'd like some more confirmation on that.