GameConfigLoader: Map whole sections, not just individual keys #6269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two reasons for this change: 1. It removes many repetitive lines of code. 2. I think it's a good idea to enable the use of old-style section names even for settings that previously haven't been settable in game INIs. Mixing the two styles in INIs (using the new style only for new settings) is not ideal, and people on the forums don't even seem to know that the new style exists (nobody knew a way to set ubershader settings per game, for instance). Encouraging everyone to start using only the new style might work long-term, but it would take take time and effort to make everyone get used to it. Considering that this commit *reduces* the amount of code by adding the ability to use old-style names for more settings, I'd say that adding this ability is worth it.
leoetlino
approved these changes
Dec 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two reasons for this change:
It removes many repetitive lines of code.
I think it's a good idea to enable the use of old-style section names even for settings that previously haven't been settable in game INIs. Mixing the two styles in INIs (using the new style only for new settings) is not ideal, and people on the forums don't even seem to know that the new style exists (nobody knew a way to set ubershader settings per game, for instance). Encouraging everyone to start using only the new style might work long-term, but it would take take time and effort to make everyone get used to it. Considering that this commit reduces the amount of code by adding the ability to use old-style names for more settings, I'd say that adding this ability is worth it.