Bumps compile API to 29 (Q) and removes deprecated calls and unnecessary casts #7864
Conversation
|
Seems that the CI needs the target 28 to succeed the build. It's possible to auto-install it if all the licenses are accepted.
I'll fix the lint errors today later |
|
Hi, we bumped the target API to 28 in a different PR recently. However, AndroidX migration is still needed. Do you want to rebase this PR? I can also do AndroidX migration in a new PR if you want. |
|
@Simonx22 sure, I'll rebase it and update this PR :) |
|
We currently have both this PR and PR #8471 fixing the same problem in the same way, which is kind of an odd situation... I guess I'll merge the other one? Since there are some small changes that this PR makes but not the other PR (like updating the file picker version and removing some typecasts), I'll leave this open in case you want to rebase the PR to only include those changes. Otherwise you can close the PR. |
|
@JosJuice no problem, I'll rebase it and check if this still makes sense |
| @@ -1,7 +1,7 @@ | |||
| apply plugin: 'com.android.application' | |||
|
|
|||
| android { | |||
| compileSdkVersion 28 | |||
| compileSdkVersion 29 | |||
There was a problem hiding this comment.
Did you test this change on Android 10? I previously also changed the SdkVersion to 29 but forgot that scoped storage is a thing, which might cause issues so I just went with 28 for now.
There was a problem hiding this comment.
targetSdkVersion 29 is what gives us scoped storage, right? I'm not aware of compileSdkVersion 29 doing the same.
There was a problem hiding this comment.
Ohh I think you're right. Should be good then!
There was a problem hiding this comment.
Maybe makes sense to explicitly set targetSdkVersion 28 until we stress the scoped storage scenario better in Android Q devices?
| @@ -89,20 +89,6 @@ public void onAttach(Context context) | |||
| mPresenter.onAttach(); | |||
| } | |||
|
|
|||
| /** | |||
| * This version of onAttach is needed for versions below Marshmallow. | |||
There was a problem hiding this comment.
We still have minSdkVersion set to 21. Will this fragment continue to work on old versions of Android despite what this comment says?
There was a problem hiding this comment.
This method is now deprecated and replaced by void onAttach(@NonNull Context context)
There was a problem hiding this comment.
And that means that it will work on older versions?
|
I think the commit message should be updated because it's still saying that it's bumping to v28 and moving dependencies to AndroidX. |
rafaeltoledo
changed the title
rafaeltoledo
changed the title
|
The commit message is still saying "Bumps target API to 29 and moves dependencies to AndroidX". |
|
I'm getting some odd behavior with this merged. The tab bar where you switch between GC/Wii/other now has a while background instead of a color background, and the actions on dialogs (e.g. yes/no) now have a color background instead of white. I'm assuming this has to do with the changes to styles.xml, but I'm not sure exactly what happened or what the proper fix is. Do either of you two know? |
|
Since Pie, Android is pushing white backgrounds with just small color accents everywhere, supposedly to make it easier to implement dark mode. That might be the case here... |
|
I'm on 8.1.0, though... But maybe it affects me anyway because that behavior is part of AndroidX? |
|
Very likely... |
|
Addressed in PR #8481. |
|
@JosJuice I can open another PR with the fixes if sounds good to you. |
|
If it's a different fix than the simple revert in PR #8481, then yes, please open a PR. |
This will help the Android client to evolve with the latest libraries (as the legacy support libs will not be shipped anymore with the com.android.support package).
This PR also makes the app compliant with the new API requirements to start later this year:
https://android-developers.googleblog.com/2019/02/expanding-target-api-level-requirements.html