Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerPC: Thread state through float helpers #7889

Open
wants to merge 1 commit into
base: master
from

Conversation

3 participants
@CrystalGamma
Copy link

CrystalGamma commented Mar 13, 2019

No description provided.

@lioncash
Copy link
Member

lioncash left a comment

You may want to consider passing by reference in cases where relevant state cannot be null, to enforce that at a type system level. Particularly given the changes are transitional.

@Tilka
Copy link
Member

Tilka left a comment

@CrystalGamma Please use the PowerPC prefix for relevant commit messages and resolve the comments you've addressed.

@CrystalGamma

This comment has been minimized.

Copy link
Author

CrystalGamma commented Mar 15, 2019

I wanted to squash at the end when the code changes are approved, since those commits are only changes to the changes in the original PR commit.

@CrystalGamma

This comment has been minimized.

Copy link
Author

CrystalGamma commented Mar 15, 2019

Re: pointers/references: the code style guidelines say "Functions that specifically modify their parameters should have the respective parameter(s) marked as a pointer so that the variables being modified are syntaxically obvious" so that's why I did that. I'm open to changing that though should you insist …

@CrystalGamma CrystalGamma force-pushed the CrystalGamma:pr-floathelpers branch from c960e35 to 23168ba Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.