PowerPC: Thread state through float helpers #7889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
reviewed
Mar 13, 2019
Source/Core/Core/PowerPC/Interpreter/Interpreter_FloatingPoint.cpp
Outdated
Show resolved
Hide resolved
Source/Core/Core/PowerPC/Interpreter/Interpreter_SystemRegisters.cpp
Outdated
Show resolved
Hide resolved
Tilka
requested changes
Mar 15, 2019
There was a problem hiding this comment.
@CrystalGamma Please use the PowerPC prefix for relevant commit messages and resolve the comments you've addressed.
|
I wanted to squash at the end when the code changes are approved, since those commits are only changes to the changes in the original PR commit. |
|
Re: pointers/references: the code style guidelines say "Functions that specifically modify their parameters should have the respective parameter(s) marked as a pointer so that the variables being modified are syntaxically obvious" so that's why I did that. I'm open to changing that though should you insist … |
CrystalGamma
force-pushed
the
pr-floathelpers
branch
from
c960e35
to
23168ba
Compare
CrystalGamma
force-pushed
the
pr-floathelpers
branch
from
23168ba
to
50b1470
Compare
CrystalGamma
force-pushed
the
pr-floathelpers
branch
from
50b1470
to
b00a704
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.