FFV1: Set coder and level to 1 #7933
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this boosts compatibility with legacy decoders as well https://bugs.dolphin-emu.org/issues/11141#note-5
vadosnaprimer
changed the title
|
This appears to break our graphics CI: https://fifoci.dolphin-emu.org/version/95e9223b2b29e8bb5c27102edc09e9df6e6fb4de/ It looks to be crashing in Dolphin itself: https://buildbot.dolphin-emu.org/#/builders/30/builds/4145/steps/6/logs/stdio |
|
Yeah sorry, I found that it was problematic yesterday and didn't have time to retract the PR. In 5.0 this patch works fine, I guess ffmpeg has been updated since then, and the option isn't there anymore. Since those options are not available anymore, the aforementioned issue can just be closed I think. Finding the working decoder now fully depends on the user. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This boosts compatibility with legacy decoders as well.
https://bugs.dolphin-emu.org/issues/11141#note-5
Explanation of those arguments:
https://trac.ffmpeg.org/wiki/Encode/FFV1