Update django and improve main page performance. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old one was dropped in django 1.10.
As selecting the list of types is slow in the current way, it's best to move the name of the types into a small lookup table. for migration: create table fifoci_type (id serial primary key, type character varying(64) not null unique); insert into fifoci_type (type) select distinct type from fifoci_result; alter table fifoci_result add type_id integer references fifoci_type; update fifoci_result r set type_id = (select id from fifoci_type where type = r.type); alter table fifoci_result alter type_id SET NOT NULL; create index on fifoci_result(type_id); alter table fifoci_result drop type;
This can be improved further with the index: create index on fifoci_result (ver_id) where (has_change or first_result);
We never want to do a full scan over the results table. So those indices are never used and are just a bad hint for postgresql to do bitmap scaning. drop index fifoci_result_first_result; drop index fifoci_result_has_change;
|
As mentioned on IRC, I would like you to introduce migrations first, then do the model changes. Otherwise great PR. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first 4 commits are to replace deprecated django functions and to update django to its newest stable release.
The last 3 commits optimize the database usage to speed up the main page. It requires a few SQL commands for migration, they are in those commit messages.