Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow logging base64-encoded queries, instead of replacing bad chars. #5615

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

PavelSafronov
Copy link
Contributor

No description provided.

@PavelSafronov
Copy link
Contributor Author

Matching GMS PR: dolthub/go-mysql-server#1667

Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@PavelSafronov PavelSafronov merged commit aaf99b4 into main Mar 23, 2023
@github-actions
Copy link

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 0.9
adds_updates_deletes 60000 60000 60000 4.89
deletes_only 0 60000 0 2.43
updates_only 0 0 60000 3.04

@github-actions
Copy link

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.07 0.71
batching batch sql 10000 1 0.09 1.89
batching by line sql 10000 1 0.08 2
blob 1 blob 200000 1 1.17 3.38 3.58
blob 2 blobs 200000 1 1.15 4.5 4.74
blob no blob 200000 1 1.15 1.35 1.43
col type datetime 200000 1 1.11 1.69 1.85
col type varchar 200000 1 0.88 2.06 2.24
config width 2 cols 200000 1 0.98 1.27 1.36
config width 32 cols 200000 1 2.38 1.49 2.09
config width 8 cols 200000 1 1.17 1.5 2.11
pk type float 200000 1 1.1 1.34 1.24
pk type int 200000 1 0.96 1.51 1.35
pk type varchar 200000 1 1.9 0.91 0.97
row count 1.6mm 1600000 1 7.4 1.46 1.5
row count 400k 400000 1 1.89 1.37 1.43
row count 800k 800000 1 3.79 1.4 1.44
secondary index four index 200000 1 4.83 0.84 0.87
secondary index no secondary 200000 1 1.16 1.32 1.38
secondary index one index 200000 1 1.45 1.42 1.54
secondary index two index 200000 1 2.65 1.03 1.09
sorting shuffled 1mm 1000000 0 7.46 1.8 1.79
sorting sorted 1mm 1000000 1 7.43 1.76 1.79

@github-actions
Copy link

@coffeegoddd DOLT

name mean mean_mult
dolt_blame_basic 39.06 1.47
dolt_blame_commit_filter 290.59 3.26
dolt_commit_ancestors_commit_filter 0.52 0.98
dolt_commits_commit_filter 0.6 1.09
dolt_diff_log_join_from_commit 153.35 1.65
dolt_diff_log_join_to_commit 152.35 1.65
dolt_diff_table_from_commit_filter 0.93 1.18
dolt_diff_table_to_commit_filter 0.94 1.22
dolt_diffs_commit_filter 0.58 1.02
dolt_history_commit_filter 0.88 1.42
dolt_log_commit_filter 0.57 1.02

@Hydrocharged Hydrocharged deleted the pavel/encode-logged-queries branch March 29, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants