Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messaging when encountering a primary key schema change during a merge. #7721

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

nicktobey
Copy link
Contributor

When a merge encounters a table that can't be merged because its primary key changed, we now:

  • Include the name of the affected table
  • Indicate whether the primary key discrepancy is between the two branches or between one branch and the common ancestor.

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once you can get CI tests passing

@coffeegoddd
Copy link
Contributor

@nicktobey DOLT

comparing_percentages
100.000000 to 100.000000
version result total
5dc2086 ok 5937457
version total_tests
5dc2086 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@nicktobey DOLT

comparing_percentages
100.000000 to 100.000000
version result total
bfe2e3f ok 5937457
version total_tests
bfe2e3f 5937457
correctness_percentage
100.0

@nicktobey nicktobey merged commit 43849f8 into main Apr 10, 2024
20 checks passed
@nicktobey nicktobey deleted the nicktobey/pk branch April 10, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants