Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dolt sql slash cmds #7940

Merged
merged 11 commits into from
Jun 4, 2024
Merged

dolt sql slash cmds #7940

merged 11 commits into from
Jun 4, 2024

Conversation

macneale4
Copy link
Contributor

Add the ability to run some dolt commands directly from the dolt sql shell.

Fixes: #6874

@macneale4 macneale4 requested a review from fulghum June 3, 2024 19:08
@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
e3cac93 ok 5937457
version total_tests
e3cac93 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
c319c61 ok 5937457
version total_tests
c319c61 5937457
correctness_percentage
100.0

fulghum
fulghum approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the first iteration. I built it locally and tried it out – very pleasant to be able to access the less verbose command line UI from within dolt sql!

Looks like you still have a couple of BATS tests failing though.

@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
a80be68 ok 5937457
version total_tests
a80be68 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
9cff5b5 ok 5937457
version total_tests
9cff5b5 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
fdfe0d8 ok 5937457
version total_tests
fdfe0d8 5937457
correctness_percentage
100.0

@macneale4 macneale4 merged commit dd7071f into main Jun 4, 2024
21 checks passed
@macneale4 macneale4 deleted the macneale4/slash-cmds branch June 4, 2024 20:05
@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
9cbf1ec ok 5937457
version total_tests
9cbf1ec 5937457
correctness_percentage
100.0

@BrewTestBot BrewTestBot mentioned this pull request Jun 5, 2024
Merged
macneale4 added a commit that referenced this pull request Jun 24, 2024
@macneale4
Revert "Merge pull request #7940 from dolthub/macneale4/slash-cmds"
7688363 
This reverts commit dd7071f, reversing
changes made to 02f4503.
macneale4 added a commit that referenced this pull request Jun 24, 2024
@macneale4
Revert "Merge pull request #7940 from dolthub/macneale4/slash-cmds" (#…
07ddfec 
…8056)

This reverts commit dd7071f, reversing
changes made to 02f4503.

Reverting slash commands to fix: 
#8050
#8022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Embed cli command in dolt sql
3 participants
@macneale4 @coffeegoddd @fulghum