Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes for schema names in reset operation #8347

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Bug fixes for schema names in reset operation #8347

merged 5 commits into from
Sep 18, 2024

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Sep 12, 2024

Also factored some methods into the procedure to make it readable

@zachmu zachmu requested a review from fulghum September 12, 2024 19:39
@coffeegoddd
Copy link
Contributor

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000
version result total
f47dfea ok 5937457
version total_tests
f47dfea 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
727c4da ok 5937457
version total_tests
727c4da 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000
version result total
8ff973a ok 5937457
version total_tests
8ff973a 5937457
correctness_percentage
100.0

fulghum
fulghum approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚢

@zachmu zachmu merged commit ae4c8c7 into main Sep 18, 2024
21 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zachmu @coffeegoddd @fulghum