Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Referencing columns within arrays #121

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Referencing columns within arrays #121

merged 1 commit into from
Feb 9, 2024

Conversation

Hydrocharged
Copy link
Collaborator

@Hydrocharged Hydrocharged commented Feb 8, 2024 •
edited
Loading

This makes use of an addition to Vitess and GMS that allows for name resolution to occur for injected expressions. The new ARRAY[...] smoke test demonstrates this.

Related PRs:

This was referenced Feb 8, 2024
Merged
Merged
max-hoffman
max-hoffman approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think this will play nicely with name resolution. The other big issue will be type coercion, but that's separable and already a preexisting problem in GMS

server/ast/expr.go Show resolved Hide resolved
@Hydrocharged Hydrocharged force-pushed the daylon/array-columns branch 3 times, most recently from ae8efb9 to 90d06cb Compare February 9, 2024 13:43
@Hydrocharged Hydrocharged merged commit f6caf50 into main Feb 9, 2024
7 checks passed
@Hydrocharged Hydrocharged deleted the daylon/array-columns branch February 9, 2024 13:58
@Hydrocharged Hydrocharged restored the daylon/array-columns branch February 9, 2024 13:58
@Hydrocharged Hydrocharged deleted the daylon/array-columns branch February 9, 2024 13:58
@BrewTestBot BrewTestBot mentioned this pull request Feb 10, 2024
Merged
@Porkepix Porkepix mentioned this pull request Feb 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-hoffman max-hoffman max-hoffman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hydrocharged @max-hoffman