Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a plethora of function tests #142

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Added a plethora of function tests #142

merged 1 commit into from
Mar 12, 2024

Conversation

Hydrocharged
Copy link
Collaborator

This adds tests for most of the functions, along with the generation code that grabs results from a running PostgreSQL 15 to create tests with.

zachmu
zachmu approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only spot checked the generated tests but the approach seems sound, nice work.

server/ast/expr.go Show resolved Hide resolved
server/functions/framework/literal.go Show resolved Hide resolved
server/functions/framework/overload_cast.go Outdated Show resolved Hide resolved
server/functions/framework/overload_deduction.go Show resolved Hide resolved
server/functions/framework/overload_deduction.go Outdated Show resolved Hide resolved
testing/generation/function_coverage/main.go Show resolved Hide resolved
testing/generation/function_coverage/output/acos_test.go Show resolved Hide resolved
testing/generation/function_coverage/output/asin_test.go Outdated Show resolved Hide resolved
testing/generation/function_coverage/output/chr_test.go Outdated Show resolved Hide resolved
@Hydrocharged Hydrocharged merged commit 22ac7a4 into main Mar 12, 2024
8 checks passed
@Hydrocharged Hydrocharged deleted the daylon/function-gen-tests branch March 12, 2024 13:33
@BrewTestBot BrewTestBot mentioned this pull request Mar 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hydrocharged @zachmu