Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parsing support for OUT and INOUT argmode for routines #166

Merged
merged 6 commits into from
Apr 8, 2024

Conversation

jennifersp
Copy link
Contributor

@jennifersp jennifersp commented Apr 4, 2024

Aggregate only allows IN and VARIADIC argument modes. Routines including functions and procedures allows IN, VARIADIC, OUT and INOUT modes. The parser will allow OUT and INOUT for aggregates, so TODO there needs a check during ast evaluation/conversion for these modes in aggregate statements.

  • small fix for supporting SETOF modifier option for CREATE FUNCTION statement.
  • small fix for supporting db.aggregate_name syntax for AGGREGATE statements.

Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

server/ast/create_aggregate.go Show resolved Hide resolved
@jennifersp jennifersp enabled auto-merge (squash) April 8, 2024 17:09
@jennifersp jennifersp merged commit 51a8edd into main Apr 8, 2024
8 checks passed
@jennifersp jennifersp deleted the jennifer/routine-arg-mode branch April 8, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants