Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for schemas #181

Merged
merged 24 commits into from
Apr 29, 2024
Merged

Support for schemas #181

merged 24 commits into from
Apr 29, 2024

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Apr 18, 2024 •
edited
Loading

Things that work:

  • Create schema
  • Explicit schema name qualifiers in statements, with and without database name qualifiers

Things that don't work:

  • Foreign keys
  • Search path support for resolving table names
  • Automatically creating a public schema for new databases
  • Revision name qualifiers (branch name DBs)

@zachmu zachmu mentioned this pull request Apr 18, 2024
Merged
Hydrocharged
Hydrocharged approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me!

server/ast/create_schema.go Show resolved Hide resolved
testing/go/schemas_test.go Show resolved Hide resolved
@zachmu zachmu merged commit 1b37960 into main Apr 29, 2024
8 checks passed
@zachmu zachmu deleted the zachmu/schemas branch April 29, 2024 22:35
@BrewTestBot BrewTestBot mentioned this pull request Apr 30, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachmu @Hydrocharged