Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement name type #202

Merged
merged 8 commits into from
Apr 30, 2024
Merged

Implement name type #202

merged 8 commits into from
Apr 30, 2024

Conversation

tbantle22
Copy link
Contributor

No description provided.

@tbantle22 tbantle22 marked this pull request as ready for review April 29, 2024 20:21
Hydrocharged
Hydrocharged approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me!

server/types/name.go Outdated Show resolved Hide resolved
testing/go/types_test.go Show resolved Hide resolved
@tbantle22 tbantle22 merged commit 5df6f24 into main Apr 30, 2024
8 checks passed
@tbantle22 tbantle22 deleted the taylor/name-type branch April 30, 2024 23:09
@BrewTestBot BrewTestBot mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbantle22 @Hydrocharged