Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement oid type #204

Merged
merged 15 commits into from
May 2, 2024
Merged

Implement oid type #204

merged 15 commits into from
May 2, 2024

Conversation

tbantle22
Copy link
Contributor

No description provided.

@tbantle22 tbantle22 marked this pull request as ready for review April 29, 2024 23:18
Hydrocharged
Hydrocharged requested changes May 1, 2024
View reviewed changes
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things that need to be changed. I'll check back over it once the changes are in to make sure everything was caught before merging.

server/cast/char.go Outdated Show resolved Hide resolved
server/cast/char.go Outdated Show resolved Hide resolved
server/cast/char.go Outdated Show resolved Hide resolved
server/cast/numeric.go Outdated Show resolved Hide resolved
server/cast/numeric.go Outdated Show resolved Hide resolved
server/cast/numeric.go Outdated Show resolved Hide resolved
server/cast/oid.go Show resolved Hide resolved
server/cast/oid.go Show resolved Hide resolved
server/types/oid.go Outdated Show resolved Hide resolved
server/types/oid.go Outdated Show resolved Hide resolved
tbantle22
tbantle22 commented May 1, 2024
View reviewed changes
server/cast/utils.go Outdated Show resolved Hide resolved
Hydrocharged
Hydrocharged approved these changes May 1, 2024
View reviewed changes
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still have a few things to fix, but it's good after that! Can never have too many tests lol

server/cast/float32.go Outdated Show resolved Hide resolved
server/cast/int64.go Outdated Show resolved Hide resolved
server/cast/utils.go Outdated Show resolved Hide resolved
server/cast/varchar.go Show resolved Hide resolved
server/types/numeric.go Show resolved Hide resolved
@tbantle22 tbantle22 merged commit 923de67 into main May 2, 2024
8 checks passed
@tbantle22 tbantle22 deleted the taylor/oid-type branch May 2, 2024 23:53
@BrewTestBot BrewTestBot mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbantle22 @Hydrocharged