Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only some queries send RowDescription message #255

Merged
merged 12 commits into from
May 15, 2024
Merged

only some queries send RowDescription message #255

merged 12 commits into from
May 15, 2024

Conversation

jennifersp
Copy link
Contributor

@jennifersp jennifersp commented May 10, 2024 •
edited
Loading

  • Only queries that returns set of rows should send RowDescription message. This includes SELECT, FETCH, SHOW, etc.

  • The CommandTag is now set by the StatementTag from the parsed query.

  • Empty query should send EmptyQueryResponse message.

@jennifersp jennifersp changed the title only SELECT and FETCH queries send RowDescription message only some queries send RowDescription message May 10, 2024
@jennifersp jennifersp marked this pull request as ready for review May 13, 2024 18:53
@jennifersp jennifersp linked an issue May 13, 2024 that may be closed by this pull request
Returned result differs from Postgres #240
Closed
Hydrocharged
Hydrocharged approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

server/connection_handler.go Show resolved Hide resolved
@jennifersp jennifersp merged commit 3817a4f into main May 15, 2024
8 checks passed
@jennifersp jennifersp deleted the jennifer/connect-datagrip branch May 15, 2024 17:47
@BrewTestBot BrewTestBot mentioned this pull request May 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Returned result differs from Postgres
2 participants
@jennifersp @Hydrocharged