Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SERIAL types along with remaining SEQUENCE functionality #287

Merged
merged 2 commits into from
May 21, 2024

Conversation

Hydrocharged
Copy link
Collaborator

Companion PRs:

This adds the SERIAL types, along with the remaining functionality for sequences that was not present in the first PR. In addition, this adds our first uses of injected analyzer steps, and introduces custom nodes used for the sequence statements (instead of stored procedures).

Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, main feedback is that we shouldn't mess around with caching intermediate state in the context if we can help it.

core/relations.go Outdated Show resolved Hide resolved
core/rootvalue.go Show resolved Hide resolved
core/sequences/merge.go Show resolved Hide resolved
core/sequences/sequence.go Outdated Show resolved Hide resolved
core/sequences/sequence.go Outdated Show resolved Hide resolved
core/context.go Outdated Show resolved Hide resolved
core/context.go Show resolved Hide resolved
core/context.go Show resolved Hide resolved
core/relations.go Outdated Show resolved Hide resolved
testing/go/create_view_test.go Outdated Show resolved Hide resolved
@Hydrocharged Hydrocharged merged commit edadbcd into main May 21, 2024
8 checks passed
@Hydrocharged Hydrocharged deleted the daylon/sequences-2 branch May 21, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants