Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added JSON types #302

Merged
merged 1 commit into from
May 29, 2024
Merged

Added JSON types #302

merged 1 commit into from
May 29, 2024

Conversation

Hydrocharged
Copy link
Collaborator

This adds JSON types, and also fixes a bug where the text types would incorrectly persist an empty string as a NULL.

@Hydrocharged Hydrocharged requested a review from zachmu May 23, 2024 17:46
zachmu
zachmu approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks fine, but I don't see the point of writing our own JSON serialization. If you need a deserializer to get your customer types out then fine, but less code is better.

server/functions/binary/json.go Outdated Show resolved Hide resolved
server/functions/framework/operators.go Outdated Show resolved Hide resolved
server/types/json_document.go Show resolved Hide resolved
server/types/jsonb.go Outdated Show resolved Hide resolved
testing/go/types_test.go Show resolved Hide resolved
@Hydrocharged Hydrocharged force-pushed the daylon/json branch 2 times, most recently from 13fe74d to 8be7596 Compare May 29, 2024 07:15
@Hydrocharged Hydrocharged merged commit b1fc050 into main May 29, 2024
9 checks passed
@Hydrocharged Hydrocharged deleted the daylon/json branch May 29, 2024 07:28
@BrewTestBot BrewTestBot mentioned this pull request Jun 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hydrocharged @zachmu