Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add smoke tests for perl, php and ruby #365

Merged
merged 2 commits into from
Jun 11, 2024
Merged

add smoke tests for perl, php and ruby #365

merged 2 commits into from
Jun 11, 2024

Conversation

jennifersp
Copy link
Contributor

No description provided.

@jennifersp jennifersp requested a review from zachmu June 10, 2024 22:29
zachmu
zachmu reviewed Jun 10, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are great to have, but they should also ensure that rows are returned correctly from select queries, with a few different common types.

Other than that looks great

testing/postgres-client-tests/php/pdo_connector_test.php Show resolved Hide resolved
zachmu
zachmu approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jennifersp jennifersp enabled auto-merge (squash) June 11, 2024 00:11
@jennifersp jennifersp merged commit e255e50 into main Jun 11, 2024
9 checks passed
@jennifersp jennifersp deleted the jennifer/pg-client-tests branch June 11, 2024 00:13
@BrewTestBot BrewTestBot mentioned this pull request Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennifersp @zachmu