Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better prepared statement support #95

Merged
merged 12 commits into from
Jan 18, 2024
Merged

Better prepared statement support #95

merged 12 commits into from
Jan 18, 2024

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Jan 18, 2024

Now handles type casts for placeholders, as well as matching a larger variety of expressions.

Companion PR:

dolthub/go-mysql-server#2272

Hydrocharged
Hydrocharged approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

testing/go/framework.go Outdated Show resolved Hide resolved
server/ast/expr.go Show resolved Hide resolved
@zachmu zachmu enabled auto-merge January 18, 2024 22:05
@zachmu zachmu merged commit c46eefd into main Jan 18, 2024
7 checks passed
@zachmu zachmu deleted the zachmu/prepared2 branch January 18, 2024 22:36
@Porkepix Porkepix mentioned this pull request Feb 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachmu @Hydrocharged