Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add support for multiple result sets through the driver.RowsNextResultSet interface #30

Merged
merged 14 commits into from
Jul 11, 2024

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Jul 4, 2024

Adds support for working with multiple ResultSets when working in multiStatements mode. Semantics of when errors are thrown, when statements are executed, and how to iterate through result sets matches the MySQL driver implementation.

This is a backwards incompatible change for existing customers using the Dolt driver in multiStatements mode. Previous versions would return the result set for the last statement, but in order to allow callers to access result sets from earlier statements, and to match the MySQL driver's behavior, the initial result set returned is for the first statement.

Customer issue: #28

@fulghum fulghum marked this pull request as ready for review July 9, 2024 23:48
@fulghum fulghum requested a review from zachmu July 10, 2024 20:27
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just minor comments

smoke_test.go Show resolved Hide resolved
smoke_test.go Show resolved Hide resolved
smoke_test.go Outdated Show resolved Hide resolved
rows.go Show resolved Hide resolved
@fulghum fulghum merged commit b7878a7 into main Jul 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants