-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add support for multiple result sets through the driver.RowsNextResultSet
interface
#30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r.RowsNextResultSet interface
…ersion of Vitess dependency and added a new test.
…the Dolt driver's behavior to the MySQL driver, and fixing tests to run correctly against the MySQL driver.
…ing non-query result sets.
zachmu
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just minor comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for working with multiple ResultSets when working in
multiStatements
mode. Semantics of when errors are thrown, when statements are executed, and how to iterate through result sets matches the MySQL driver implementation.This is a backwards incompatible change for existing customers using the Dolt
driver
inmultiStatements
mode. Previous versions would return the result set for the last statement, but in order to allow callers to access result sets from earlier statements, and to match the MySQL driver's behavior, the initial result set returned is for the first statement.Customer issue: #28