Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recost LookupJoins to remove special casing for indexes where every column is used in a filter. #1889

Merged
merged 5 commits into from
Jul 25, 2023
Merged

Recost LookupJoins to remove special casing for indexes where every column is used in a filter. #1889

merged 5 commits into from
Jul 25, 2023

Commits on Jul 24, 2023

  1. Recost LookupJoins to remove special casing for indexes where every c… 

    …olumn is used in a filter.
    @nicktobey
    nicktobey committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    3f02723 View commit details
    Browse the repository at this point in the history

  2. Many planning tests expect results consistent with xy.y_idx being u… 

    …nique. Rather than changes those tests, I made the index unique.
    @nicktobey
    nicktobey committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    b1bb987 View commit details
    Browse the repository at this point in the history

  3. Update planning tests. In cases where we suspect the plan is suboptim… 

    …al due to a bug, link to the bug.

(Linking to the bug is not possible in `query_plans.go` because the tests are generated.)
    @nicktobey
    nicktobey committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    01dac86 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Add regression test for #1889

    @nicktobey
    nicktobey committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    fc9dc40 View commit details
    Browse the repository at this point in the history

  2. Add extra rows to join table in QueryPlanTests. 

    At extremely low cardinalities, we may pick a non-unique index with more columns than a unique index with fewer columns. This behavior disappears at higher cardinalities, which is where we care more about the performance.
    @nicktobey
    nicktobey committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    0c413d3 View commit details
    Browse the repository at this point in the history