Default sql mode for common path #2520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulghum
approved these changes
May 29, 2024
sql/sql_mode.go
Outdated
| @@ -30,8 +30,24 @@ const ( | |||
| NoAutoValueOnZero = "NO_AUTO_VALUE_ON_ZERO" | |||
| NoEngineSubstitution = "NO_ENGINE_SUBSTITUTION" | |||
| StrictTransTables = "STRICT_TRANS_TABLES" | |||
| defaultSqlMode = "no_engine_substitution,only_full_group_by,strict_trans_tables" | |||
There was a problem hiding this comment.
(minor) You might consider exposing this constant (and uppercasing?) – then you could reference this default from system_variables.go instead of relying on those to match up. That way, if someone does change system_variables.go to change that value in the future, they'd have to come change it here and make sure this code gets updated, too. (you could also just reuse defaultSqlMode on line 47 if you want to avoid that extra strings.Join call.)
|
Additional work is required for integration with Dolt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bit strange & verbose, but has a noticeable effect for small queries.
perf here: dolthub/dolt#7915