Vinai/load data basic network handling. #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aner expressions...
zachmu
reviewed
Feb 25, 2021
go/mysql/conn.go
Outdated
| c.recycleReadPacket() | ||
| query := c.parseComQuery(data) | ||
| //if strings.Contains(strings.ToLower(query), "local"){ |
There was a problem hiding this comment.
How are you actually going to check this? You have to parse the query, right?
There was a problem hiding this comment.
Yea I move the actual call to go-mysql-server
go/mysql/conn.go
Outdated
|
|
||
| // Write the file to a temporary directory. | ||
| // TODO: Get the tmpdir config params from here | ||
| err = ioutil.WriteFile(fileName, fileData, 0644) |
There was a problem hiding this comment.
There can be more than one packet with file data, right?
There was a problem hiding this comment.
Good point. Is the idea here to keep waiting with a timeout or something like that?
go/mysql/conn.go
Outdated
| if sequence != c.sequence { | ||
| return 0, vterrors.Errorf(vtrpc.Code_INTERNAL, "invalid sequence, expected %v got %v", c.sequence, sequence) | ||
| } | ||
| //sequence := uint8(header[3]) |
There was a problem hiding this comment.
Will remove this edit. Was having trouble with code earlier in the process...
VinaiRachakonda
changed the title
zachmu
approved these changes
Mar 1, 2021
go/mysql/conn.go
Outdated
| fileData, err = c.readEphemeralPacket(); | ||
| } | ||
|
|
||
| if len(fileData) != 0 { |
There was a problem hiding this comment.
Seems like this is now impossible due to the above loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic steps for packet management. Have text with files up to 1gb.
Definitely some more work to be done here in the future. Is it optimal to write everything to a file or can we do something better? Regardless, I think this is a good enough start for Max to get unblocked while I continue to build more functionality.