Max/drop pk #83
Merged
Max/drop pk #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go/vt/sqlparser/ast.go
Outdated
| @@ -2288,18 +2288,24 @@ type IndexSpec struct { | |||
| Columns []*IndexColumn | |||
| // Options contains the index options when creating an index | |||
| Options []*IndexOption | |||
| // Primary indicates a PRIMARY KEY create or delete operation | |||
| Primary bool | |||
There was a problem hiding this comment.
This should be a part of the type parameter not a new field on a struct
go/vt/sqlparser/ast.go
Outdated
| @@ -2288,18 +2288,24 @@ type IndexSpec struct { | |||
| Columns []*IndexColumn | |||
| // Options contains the index options when creating an index | |||
| Options []*IndexOption | |||
| // Primary indicates a PRIMARY KEY create or delete operation | |||
| Primary bool | |||
| } | |||
|
|
|||
| func (idx *IndexSpec) Format(buf *TrackedBuffer) { | |||
There was a problem hiding this comment.
Why are we using this as an index and not a constraint?
go/vt/sqlparser/parse_test.go
Outdated
| input: "alter table a add primary key", | ||
| output: "alter table a", | ||
| input: "alter table a add primary key (a, b)", | ||
| output: "alter table a add constraint PRIMARY primary key (a, b)", |
There was a problem hiding this comment.
this seems like incorrect formatting. The output wouldn't run on mysql
zachmu
approved these changes
Jul 29, 2021
go/vt/sqlparser/sql.y
Outdated
| @@ -2174,6 +2174,15 @@ constraint_symbol_opt: | |||
| $$ = string($2) | |||
| } | |||
|
|
|||
| pk_symbol_opt: | |||
Signed-off-by: Vinai Rachakonda <rachakondavinai@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.