Feature/scanner/block indicators #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we need to be able to reset the indents to nil/starting in the scanner
Also reorganized the main loop of scan_next_token, adding comment placeholders for the remaining missing token fetchers
Before we only checked for the existence of a saved key, but *didn't* also check that it was still valid / possible. This lead to a subtle error wherein scalar that weren't valid keys (anymore) would still be picked up and used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds block indicator support to the
Scanner. It also tightens up the handling of stale / expired possible keys, and adds unit tests for both cases.Components
BlockSequenceStart,BlockMappingStartBlockEndtokens (indentation levels)BlockEntrytoken (-)Scanner.valuesaved key validation