Post debug builds to releases, bump required versions #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dom96
approved these changes
Jan 13, 2020
| @@ -24,13 +24,14 @@ script: | |||
| - nim c src/choosenim | |||
| - nimble test | |||
There was a problem hiding this comment.
we might need to ensure that nimble test doesn't recompile in release mode via nimble build or something.
There was a problem hiding this comment.
Tester builds with nimble build which does not create a release build. We later run nimble build -d:release which does. CI output shows the different file sizes.
https://travis-ci.org/genotrance/choosenim/jobs/636552336#L2824
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.