Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double log output when using httpbeast #286

Closed
niv opened this issue Nov 23, 2021 · 7 comments
Closed

double log output when using httpbeast #286

niv opened this issue Nov 23, 2021 · 7 comments

Comments

@niv
Copy link

niv commented Nov 23, 2021

  • Run jester with httpbeast
  • Have custom logging already set up
  • HttpBeast adds a second logger (passed through settings/initSettings/...) with no way to dodge this short of rewriting the whole serve*(Jester) function.
  • This results in all logging output on stdout being duplicated
@ThomasTJdev
Copy link
Contributor

I agree. It would be nice to be able to specify the logging. For now I use something like this:

if logging.getHandlers().len() > 0:
  for logger in getHandlers():
    logger.fmtStr = "[$datetime] - $levelname: "
    logger.levelThreshold = (when defined(release): lvlInfo else: lvlAll)

@ThomasTJdev
Copy link
Contributor

I have a PR for this one on my to-do list. @dom96, do you have any preferences to a solution?

@ohPaco
Copy link

ohPaco commented Apr 12, 2022

@ThomasTJdev would like to see your changes for the fix, had you closed the PR?

@ThomasTJdev
Copy link
Contributor

@ohPaco I have not started on it yet. I would prefer to have dom96's thoughts on a preferable solution before starting.

@ohPaco
Copy link

ohPaco commented Apr 27, 2022

@ThomasTJdev understood. @dom96 would you be able to comment on this issue?

@dom96
Copy link
Owner

dom96 commented Apr 27, 2022

I'm not sure what options there are. I would need to have a look to know. If you guys had a look and have some ideas let me know and we can discuss which one would be best.

@ohPaco
Copy link

ohPaco commented May 30, 2022

I'm not sure what options there are. I would need to have a look to know. If you guys had a look and have some ideas let me know and we can discuss which one would be best.

@ThomasTJdev having looked into the issue, do you have any ideas?

dom96 added a commit to dom96/httpbeast that referenced this issue Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants