Add net.Dialer override, configurable through options #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NewXYZ pattern is limiting in the maximum number of parameters that could be encoded in the method.
ydnar
requested changes
Jun 22, 2021
The ResolverOption type is a public alias for the private resolverOption - useful e.g. if multiple reoslver should use the same settings. The resolverOption is now potentially returning an error.
ydnar
reviewed
Jun 29, 2021
|
I am not aware of anything I should add, please let me know if there are any further issues with this PR |
ydnar
requested changes
Sep 8, 2021
There was a problem hiding this comment.
Hi there, thanks for your patience.
The public API looks good, but the internal implementation should be tweaked. The main issue is that the various cache options (Expiring and WithCapacity) both create a cache.
A simple fix could be to add a capacity int field to Resolver, and then create the cache once after the various options are run on the *Resolver.
SkYNewZ
approved these changes
Apr 27, 2022
|
Superseded by #92. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #40
The
dns.ClientexposesDialer: net.Dialerwhich can be used to specify the local IP address (and various other options).The
NewXXXmethods started to become larger and larger, so I've added an Options based configuration / constructor - a common way to expose more options to clients without opening the datastructure.Feel free to mangle this in any way you like. I saw #40 and thought I could need something like this and hacked it up.