26 new fixes for substitutions.json #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks so much; this is great! I don't think we should change the comma style choice (Oxford vs. not), as IMO that's an authorial style choice and depends on the situation. But otherwise these are great! I'll push a few fixups, including undoing the Oxford comma changes, and then do a merge and release. |
domenic
reviewed
Jan 1, 2021
| { | ||
| "before": "real ly", | ||
| "after": "really", | ||
| "comment": "There's an empty em element in the middle of this word that gets converted to a space" |
There was a problem hiding this comment.
Nice find with this one. I'll do a larger change to stop adding spaces in place of completely-empty elements; that fixes a lot of extra spaces (although most of those spaces are invisible).
|
Alright, I merged this all as v4.11.0...v4.12.0 and released v4.12.0! Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just finished reading Worm for the first time, and I loved it! Thanks so much for making this scraper. While I was reading, I bookmarked all the typos I found, and added them to
substitutions.json.I tried to stick as closely as possible to Wildbow's original writing, and make the fixes as unobtrusive as possible, but I'm absolutely open to other opinions on the changes.