This repository has been archived by the owner on Dec 4, 2018. It is now read-only.

Not all jsonparse errors are handled by JSONStream #136

Open

ataube opened this issue Jul 5, 2017 · 1 comment · May be fixed by #138

ataube commented Jul 5, 2017

The underlying jsonparse lib triggers one specific error which is not handled by JSONStream:
Look here:
https://github.com/creationix/jsonparse/blob/master/jsonparse.js#L321

And here:
https://github.com/dominictarr/JSONStream/blob/master/index.js#L140

It would be helpful if JSONStream could also wrap this error as an Invalid JSON message to have a consistent error contract one can check for.

The text was updated successfully, but these errors were encountered:

Owner

dominictarr commented Jul 6, 2017

sure, I would be happy to merge this pull request!

ataube linked a pull request

that will close this issue

Handle jsonparse errors consistently #138

Open

juliangruber mentioned this issue

Why duplexer2 calling with bubbleErrors equal false? juliangruber/multipipe#47

Closed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.