Build transposition table #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 47e39ba.
ddugovic
force-pushed
the
lower-mem-alphabeta-2
branch
from
72e9a7a
to
863c8b4
Compare
ddugovic
force-pushed
the
lower-mem-alphabeta-2
branch
from
863c8b4
to
aa7bb1b
Compare
This reverts commit f9e6eea.
domino14
reviewed
Aug 28, 2022
domino14
reviewed
Aug 28, 2022
endgame/alphabeta/alphabeta.go
Outdated
| @@ -366,6 +391,7 @@ func (s *Solver) Solve(plies int) (float32, []*move.Move, error) { | |||
|
|
|||
| tstart := time.Now() | |||
| s.mmCount = 0 | |||
| s.zobrist.Initialize(s.game.Board().Dim(), alphabet.MaxAlphabetSize+1, alphabet.MaxAlphabetSize+1) | |||
There was a problem hiding this comment.
for norwegian, the second argument to this function is smaller than the third argument. This is because Norwegian can make the blank a bunch of letters that are not actually in its tile distribution. I don't think I have this argument readily available but it should be kept in mind that we need to modify it for Norwegian.
domino14
reviewed
Aug 28, 2022
zobrist/hash.go
Outdated
| z.posTable[i] = make([]int64, numtiles+numblankletters) | ||
| for j := 0; j < numtiles+numblankletters; j++ { | ||
| z.posTable[i][j] = int64(frand.Uint64n(bignum)) | ||
| z.posTable[i] = make([]uint64, 256) |
There was a problem hiding this comment.
what happens if you use numtiles+numblankletters?
There was a problem hiding this comment.
I was observing index out of bounds accesses... spent the better part of an hour trying to make it work before trying 256 instead.
There was a problem hiding this comment.
I've committed this suggestion.
domino14
reviewed
Aug 28, 2022
ddugovic
force-pushed
the
lower-mem-alphabeta-2
branch
from
f62cb7a
to
993a8cc
Compare
ddugovic
force-pushed
the
lower-mem-alphabeta-2
branch
from
dbb07db
to
616b3c4
Compare
ddugovic
force-pushed
the
lower-mem-alphabeta-2
branch
from
575306f
to
779376c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.