Fixed some issues with channel names #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warnings are issued if there are douplicate channel names when accessing with data_file[channel_name] or when calling channel_dict(). For example, try the test file with data_file[''] and data_file.channel_dict(1). The change at line 660 is so that data_file.channel_names and data_file.channel_name(g, c) give the same names. Before data_file.channel_names had 'None' for missing channel names, now it's ''. The change in __getitem__ is to make data_file[''] work. Now I use the dict _name_to_indices instead of channel_search() to map from channel name to group and channel inidices.
In several tdm files I've tested, there are more "block" tags than "tdm_channel" tags, which made `assert(len(blocks) == len(channel_names))` to fail. This might be i dirty fix to that problem, but I don't have a better idea right now. What I noted with those tdm file was that the few extra "block" tags are always the last ones, they always have valueType="eInt16Usi", and their id is always linked to a "flags" tag instead of a "double_sequence" or "long_sequence" tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warnings are issued if there are douplicate channel names when accessing with data_file[channel_name] or when calling channel_dict().
For example, try the test file with data_file[''] and data_file.channel_dict(1).
The change at line 660 is so that data_file.channel_names and data_file.channel_name(g, c) give the same names. Before data_file.channel_names had 'None' for missing channel names, now it's ''.
The change in getitem is to make data_file[''] work. Now I use the dict _name_to_indices instead of channel_search() to map from channel name to group and channel inidices.